Skip to content

Commit

Permalink
regmap: Make return code checks consistent
Browse files Browse the repository at this point in the history
The range code was written to check for return codes less than zero as
errors but throughout the rest of the API return codes not equal to zero
are errors. Change all these checks to match the house style.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Mark Brown committed Oct 15, 2012
1 parent 98bc7df commit 0ff3e62
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/base/regmap/regmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ struct regmap *regmap_init(struct device *dev,
}

ret = regcache_init(map, config);
if (ret < 0)
if (ret != 0)
goto err_range;

regmap_debugfs_init(map, config->name);
Expand Down Expand Up @@ -803,7 +803,7 @@ static int _regmap_select_page(struct regmap *map, unsigned int *reg,

map->work_buf = orig_work_buf;

if (ret < 0)
if (ret != 0)
return ret;
}

Expand Down Expand Up @@ -854,7 +854,7 @@ static int _regmap_raw_write(struct regmap *map, unsigned int reg,
if (range) {
ret = _regmap_select_page(map, &reg, range,
val_len / map->format.val_bytes);
if (ret < 0)
if (ret != 0)
return ret;
}

Expand Down Expand Up @@ -930,7 +930,7 @@ int _regmap_write(struct regmap *map, unsigned int reg,
range = _regmap_range_lookup(map, reg);
if (range) {
ret = _regmap_select_page(map, &reg, range, 1);
if (ret < 0)
if (ret != 0)
return ret;
}

Expand Down Expand Up @@ -1096,7 +1096,7 @@ static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
if (range) {
ret = _regmap_select_page(map, &reg, range,
val_len / map->format.val_bytes);
if (ret < 0)
if (ret != 0)
return ret;
}

Expand Down

0 comments on commit 0ff3e62

Please sign in to comment.