Skip to content

Commit

Permalink
ocfs2: Fix writeout in ocfs2_data_convert_worker()
Browse files Browse the repository at this point in the history
Commit f1f5406 "optimized"
ocfs2_data_convert_worker() to "only do work for regular files".
Unfortunately, I left out a '!', which casued it to *skip* regular files.
This was hidden from testing until recently because the default data
journaling mode (data=ordered) doesn't exercise this code.

Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
  • Loading branch information
Mark Fasheh committed Mar 3, 2008
1 parent 7ad8b3d commit 1044e40
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/ocfs2/dlmglue.c
Original file line number Diff line number Diff line change
Expand Up @@ -3042,7 +3042,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
inode = ocfs2_lock_res_inode(lockres);
mapping = inode->i_mapping;

if (S_ISREG(inode->i_mode))
if (!S_ISREG(inode->i_mode))
goto out;

/*
Expand Down

0 comments on commit 1044e40

Please sign in to comment.