Skip to content

Commit

Permalink
drivers/misc/apds9802als.c: fix signedness bug
Browse files Browse the repository at this point in the history
i2c_smbus_read_byte_data() may return negative error code.  This is not
seen to als_sensing_range_store() as the result is stored in unsigned int.

Made it signed.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Cc: Hong Liu <hong.liu@intel.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Anantha Narayanan <anantha.narayanan@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Vasiliy Kulikov authored and Linus Torvalds committed Nov 12, 2010
1 parent 90482e4 commit 1093736
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/misc/apds9802als.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ static ssize_t als_sensing_range_store(struct device *dev,
{
struct i2c_client *client = to_i2c_client(dev);
struct als_data *data = i2c_get_clientdata(client);
unsigned int ret_val;
int ret_val;
unsigned long val;

if (strict_strtoul(buf, 10, &val))
Expand Down

0 comments on commit 1093736

Please sign in to comment.