Skip to content

Commit

Permalink
staging: comedi: me4000: use dev->irq to save the irq number
Browse files Browse the repository at this point in the history
Use the irq variable provided in the comedi_device to save the
irq number and remove it from the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Sep 8, 2012
1 parent e1d7ccb commit 109daa7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 4 additions & 4 deletions drivers/staging/comedi/drivers/me4000.c
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ static int init_board_info(struct comedi_device *dev, struct pci_dev *pci_dev_p)
/* spin_lock_init(&info->ai_ctrl_lock); */

/* Get the irq assigned to the board */
info->irq = pci_dev_p->irq;
dev->irq = pci_dev_p->irq;

return 0;
}
Expand Down Expand Up @@ -1266,7 +1266,7 @@ static irqreturn_t me4000_ai_isr(int irq, void *dev_id)
s->async->events = 0;

/* Check if irq number is right */
if (irq != info->irq) {
if (irq != dev->irq) {
printk(KERN_ERR
"comedi%d: me4000: me4000_ai_isr(): "
"Incorrect interrupt num: %d\n", dev->minor, irq);
Expand Down Expand Up @@ -1876,8 +1876,8 @@ static int me4000_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->range_table = &me4000_ai_range;
s->insn_read = me4000_ai_insn_read;

if (info->irq > 0) {
if (request_irq(info->irq, me4000_ai_isr,
if (dev->irq > 0) {
if (request_irq(dev->irq, me4000_ai_isr,
IRQF_SHARED, "ME-4000", dev)) {
printk
("comedi%d: me4000: me4000_attach(): "
Expand Down
2 changes: 0 additions & 2 deletions drivers/staging/comedi/drivers/me4000.h
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,6 @@ struct me4000_info {

struct pci_dev *pci_dev_p; /* General PCI information */

unsigned int irq; /* IRQ assigned from the PCI BIOS */

unsigned int ao_readback[4];
};

Expand Down

0 comments on commit 109daa7

Please sign in to comment.