Skip to content

Commit

Permalink
Bluetooth: bt3c_cs: clean up obsolete functions
Browse files Browse the repository at this point in the history
simple_strtoul is obsolete, use kstrtoul instead reported by checkpatch.

Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Prasanna Karthik authored and Marcel Holtmann committed Sep 17, 2015
1 parent 8f9d02f commit 10bd973
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions drivers/bluetooth/bt3c_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,8 @@ static int bt3c_load_firmware(struct bt3c_info *info,
{
char *ptr = (char *) firmware;
char b[9];
unsigned int iobase, size, addr, fcs, tmp;
unsigned int iobase, tmp;
unsigned long size, addr, fcs;
int i, err = 0;

iobase = info->p_dev->resource[0]->start;
Expand All @@ -478,15 +479,18 @@ static int bt3c_load_firmware(struct bt3c_info *info,

memset(b, 0, sizeof(b));
memcpy(b, ptr + 2, 2);
size = simple_strtoul(b, NULL, 16);
if (kstrtoul(b, 16, &size) < 0)
return -EINVAL;

memset(b, 0, sizeof(b));
memcpy(b, ptr + 4, 8);
addr = simple_strtoul(b, NULL, 16);
if (kstrtoul(b, 16, &addr) < 0)
return -EINVAL;

memset(b, 0, sizeof(b));
memcpy(b, ptr + (size * 2) + 2, 2);
fcs = simple_strtoul(b, NULL, 16);
if (kstrtoul(b, 16, &fcs) < 0)
return -EINVAL;

memset(b, 0, sizeof(b));
for (tmp = 0, i = 0; i < size; i++) {
Expand Down

0 comments on commit 10bd973

Please sign in to comment.