Skip to content

Commit

Permalink
viotape: Use unlocked_ioctl
Browse files Browse the repository at this point in the history
This pushes the BKL down into the driver.  Based on a patch by Alan Cox.

We need to do it this way for now as the inode parameter of viotap_ioctl
is used internally as a flag.  We should do a further cleanup patch.

Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Stephen Rothwell authored and Paul Mackerras committed Jun 30, 2008
1 parent 74f0609 commit 10c0ad4
Showing 1 changed file with 18 additions and 6 deletions.
24 changes: 18 additions & 6 deletions drivers/char/viotape.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include <linux/completion.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#include <linux/smp_lock.h>

#include <asm/uaccess.h>
#include <asm/ioctls.h>
Expand Down Expand Up @@ -677,6 +678,17 @@ static int viotap_ioctl(struct inode *inode, struct file *file,
return ret;
}

static long viotap_unlocked_ioctl(struct file *file,
unsigned int cmd, unsigned long arg)
{
long rc;

lock_kernel();
rc = viotap_ioctl(file->f_path.dentry->d_inode, file, cmd, arg);
unlock_kernel();
return rc;
}

static int viotap_open(struct inode *inode, struct file *file)
{
HvLpEvent_Rc hvrc;
Expand Down Expand Up @@ -783,12 +795,12 @@ static int viotap_release(struct inode *inode, struct file *file)
}

const struct file_operations viotap_fops = {
.owner = THIS_MODULE,
.read = viotap_read,
.write = viotap_write,
.ioctl = viotap_ioctl,
.open = viotap_open,
.release = viotap_release,
.owner = THIS_MODULE,
.read = viotap_read,
.write = viotap_write,
.unlocked_ioctl = viotap_unlocked_ioctl,
.open = viotap_open,
.release = viotap_release,
};

/* Handle interrupt events for tape */
Expand Down

0 comments on commit 10c0ad4

Please sign in to comment.