Skip to content

Commit

Permalink
[SCSI] add ability to deny binding to SPI transport class
Browse files Browse the repository at this point in the history
This patch is necessary if we begin exposing underlying physical disks
(which can attach to the SPI transport class) of the hardware RAID
cards, since we don't want any SPI parameters binding to the RAID
devices.

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
James Bottomley authored and James Bottomley committed Aug 14, 2005
1 parent 3a4f5c6 commit 10c1b88
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
11 changes: 10 additions & 1 deletion drivers/scsi/scsi_transport_spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1082,6 +1082,7 @@ static int spi_device_match(struct attribute_container *cont,
{
struct scsi_device *sdev;
struct Scsi_Host *shost;
struct spi_internal *i;

if (!scsi_is_sdev_device(dev))
return 0;
Expand All @@ -1094,13 +1095,17 @@ static int spi_device_match(struct attribute_container *cont,
/* Note: this class has no device attributes, so it has
* no per-HBA allocation and thus we don't need to distinguish
* the attribute containers for the device */
i = to_spi_internal(shost->transportt);
if (i->f->deny_binding && i->f->deny_binding(sdev->sdev_target))
return 0;
return 1;
}

static int spi_target_match(struct attribute_container *cont,
struct device *dev)
{
struct Scsi_Host *shost;
struct scsi_target *starget;
struct spi_internal *i;

if (!scsi_is_target_device(dev))
Expand All @@ -1112,7 +1117,11 @@ static int spi_target_match(struct attribute_container *cont,
return 0;

i = to_spi_internal(shost->transportt);

starget = to_scsi_target(dev);

if (i->f->deny_binding && i->f->deny_binding(starget))
return 0;

return &i->t.target_attrs.ac == cont;
}

Expand Down
1 change: 1 addition & 0 deletions include/scsi/scsi_transport_spi.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ struct spi_function_template {
void (*set_hold_mcs)(struct scsi_target *, int);
void (*get_signalling)(struct Scsi_Host *);
void (*set_signalling)(struct Scsi_Host *, enum spi_signal_type);
int (*deny_binding)(struct scsi_target *);
/* The driver sets these to tell the transport class it
* wants the attributes displayed in sysfs. If the show_ flag
* is not set, the attribute will be private to the transport
Expand Down

0 comments on commit 10c1b88

Please sign in to comment.