Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 356639
b: refs/heads/master
c: fe9c1db
h: refs/heads/master
i:
  356637: f9e0a19
  356635: 7c6cb5a
  356631: dedac55
  356623: 0347360
  356607: 818a787
v: v3
  • Loading branch information
Al Viro committed Feb 3, 2013
1 parent 4957b41 commit 10cd975
Show file tree
Hide file tree
Showing 5 changed files with 43 additions and 19 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 322a56cb1fcbe228eee5cdb8a9c6df9f797d998c
refs/heads/master: fe9c1db2cfc363cd30ecfe6480481b280abf8c0a
3 changes: 3 additions & 0 deletions trunk/arch/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,9 @@ config GENERIC_SIGALTSTACK
config GENERIC_COMPAT_RT_SIGPROCMASK
bool

config GENERIC_COMPAT_RT_SIGPENDING
bool

#
# ABI hall of shame
#
Expand Down
4 changes: 4 additions & 0 deletions trunk/include/linux/compat.h
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,10 @@ asmlinkage long compat_sys_rt_sigprocmask(int how, compat_sigset_t __user *set,
compat_sigset_t __user *oset,
compat_size_t sigsetsize);
#endif
#ifdef CONFIG_GENERIC_COMPAT_RT_SIGPENDING
asmlinkage long compat_sys_rt_sigpending(compat_sigset_t __user *uset,
compat_size_t sigsetsize);
#endif
asmlinkage long compat_sys_sysinfo(struct compat_sysinfo __user *info);
asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd,
unsigned long arg);
Expand Down
1 change: 0 additions & 1 deletion trunk/include/linux/signal.h
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,6 @@ extern int group_send_sig_info(int sig, struct siginfo *info, struct task_struct
extern int __group_send_sig_info(int, struct siginfo *, struct task_struct *);
extern long do_rt_tgsigqueueinfo(pid_t tgid, pid_t pid, int sig,
siginfo_t *info);
extern long do_sigpending(void __user *, unsigned long);
extern int do_sigtimedwait(const sigset_t *, siginfo_t *,
const struct timespec *);
extern int sigprocmask(int, sigset_t *, sigset_t *);
Expand Down
52 changes: 35 additions & 17 deletions trunk/kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -2654,28 +2654,19 @@ COMPAT_SYSCALL_DEFINE4(rt_sigprocmask, int, how, compat_sigset_t __user *, nset,
#endif
#endif

long do_sigpending(void __user *set, unsigned long sigsetsize)
static int do_sigpending(void *set, unsigned long sigsetsize)
{
long error = -EINVAL;
sigset_t pending;

if (sigsetsize > sizeof(sigset_t))
goto out;
return -EINVAL;

spin_lock_irq(&current->sighand->siglock);
sigorsets(&pending, &current->pending.signal,
sigorsets(set, &current->pending.signal,
&current->signal->shared_pending.signal);
spin_unlock_irq(&current->sighand->siglock);

/* Outside the lock because only this thread touches it. */
sigandsets(&pending, &current->blocked, &pending);

error = -EFAULT;
if (!copy_to_user(set, &pending, sigsetsize))
error = 0;

out:
return error;
sigandsets(set, &current->blocked, set);
return 0;
}

/**
Expand All @@ -2684,10 +2675,37 @@ long do_sigpending(void __user *set, unsigned long sigsetsize)
* @set: stores pending signals
* @sigsetsize: size of sigset_t type or larger
*/
SYSCALL_DEFINE2(rt_sigpending, sigset_t __user *, set, size_t, sigsetsize)
SYSCALL_DEFINE2(rt_sigpending, sigset_t __user *, uset, size_t, sigsetsize)
{
sigset_t set;
int err = do_sigpending(&set, sigsetsize);
if (!err && copy_to_user(uset, &set, sigsetsize))
err = -EFAULT;
return err;
}

#ifdef CONFIG_COMPAT
#ifdef CONFIG_GENERIC_COMPAT_RT_SIGPENDING
COMPAT_SYSCALL_DEFINE2(rt_sigpending, compat_sigset_t __user *, uset,
compat_size_t, sigsetsize)
{
return do_sigpending(set, sigsetsize);
#ifdef __BIG_ENDIAN
sigset_t set;
int err = do_sigpending(&set, sigsetsize);
if (!err) {
compat_sigset_t set32;
sigset_to_compat(&set32, &set);
/* we can get here only if sigsetsize <= sizeof(set) */
if (copy_to_user(uset, &set32, sigsetsize))
err = -EFAULT;
}
return err;
#else
return sys_rt_sigpending((sigset_t __user *)uset, sigsetsize);
#endif
}
#endif
#endif

#ifndef HAVE_ARCH_COPY_SIGINFO_TO_USER

Expand Down Expand Up @@ -3216,7 +3234,7 @@ int __compat_save_altstack(compat_stack_t __user *uss, unsigned long sp)
*/
SYSCALL_DEFINE1(sigpending, old_sigset_t __user *, set)
{
return do_sigpending(set, sizeof(*set));
return sys_rt_sigpending((sigset_t __user *)set, sizeof(old_sigset_t));
}

#endif
Expand Down

0 comments on commit 10cd975

Please sign in to comment.