Skip to content

Commit

Permalink
do_pipe cleanup: drop its last user in arch/alpha/
Browse files Browse the repository at this point in the history
The last user of do_pipe is in arch/alpha/, after replacing it with
do_pipe_flags, the do_pipe can be totally dropped.

Signed-off-by: Cheng Renquan <crquan@gmail.com>
Acked-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Cheng Renquan authored and Al Viro committed Mar 27, 2009
1 parent 723be1f commit 10f303a
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 9 deletions.
3 changes: 2 additions & 1 deletion arch/alpha/kernel/entry.S
Original file line number Diff line number Diff line change
Expand Up @@ -903,8 +903,9 @@ sys_alpha_pipe:
stq $26, 0($sp)
.prologue 0

mov $31, $17
lda $16, 8($sp)
jsr $26, do_pipe
jsr $26, do_pipe_flags

ldq $26, 0($sp)
bne $0, 1f
Expand Down
2 changes: 0 additions & 2 deletions arch/alpha/kernel/osf_sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@
#include <asm/hwrpb.h>
#include <asm/processor.h>

extern int do_pipe(int *);

/*
* Brk needs to return an error. Still support Linux's brk(0) query idiom,
* which OSF programs just shouldn't be doing. We're still not quite
Expand Down
5 changes: 0 additions & 5 deletions fs/pipe.c
Original file line number Diff line number Diff line change
Expand Up @@ -1034,11 +1034,6 @@ int do_pipe_flags(int *fd, int flags)
return error;
}

int do_pipe(int *fd)
{
return do_pipe_flags(fd, 0);
}

/*
* sys_pipe() is the normal C calling standard for creating
* a pipe. It's not the way Unix traditionally does this, though.
Expand Down
1 change: 0 additions & 1 deletion include/linux/fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -1881,7 +1881,6 @@ static inline void allow_write_access(struct file *file)
if (file)
atomic_inc(&file->f_path.dentry->d_inode->i_writecount);
}
extern int do_pipe(int *);
extern int do_pipe_flags(int *, int);
extern struct file *create_read_pipe(struct file *f, int flags);
extern struct file *create_write_pipe(int flags);
Expand Down

0 comments on commit 10f303a

Please sign in to comment.