Skip to content

Commit

Permalink
gpiolib-acpi: Fix error checks in interrupt requesting
Browse files Browse the repository at this point in the history
Print error message if requesting an interrupt fails.
Use int instead of unsigned for interrupts in case of error values

Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Mathias Nyman authored and Linus Walleij committed Feb 4, 2013
1 parent de0ccf7 commit 1107ca1
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions drivers/gpio/gpiolib-acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
struct acpi_resource *res;
acpi_handle handle, ev_handle;
acpi_status status;
unsigned int pin, irq;
unsigned int pin;
int irq, ret;
char ev_name[5];

if (!chip->dev || !chip->to_irq)
Expand Down Expand Up @@ -126,11 +127,15 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
continue;

/* Assume BIOS sets the triggering, so no flags */
devm_request_threaded_irq(chip->dev, irq, NULL,
ret = devm_request_threaded_irq(chip->dev, irq, NULL,
acpi_gpio_irq_handler,
0,
"GPIO-signaled-ACPI-event",
ev_handle);
if (ret)
dev_err(chip->dev,
"Failed to request IRQ %d ACPI event handler\n",
irq);
}
}
EXPORT_SYMBOL(acpi_gpiochip_request_interrupts);

0 comments on commit 1107ca1

Please sign in to comment.