Skip to content

Commit

Permalink
staging: comedi: ni_daq_dio24: remove pcmcia_device private data
Browse files Browse the repository at this point in the history
The private data, struct local_info_t, is not being used in the
driver. Remove it as well as the kzalloc/kfree.

Also, don't set the 'pcmcia_cur_dev' variable unless the pcmcia
probe is successful.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Feb 4, 2013
1 parent 07c5b44 commit 1122150
Showing 1 changed file with 2 additions and 17 deletions.
19 changes: 2 additions & 17 deletions drivers/staging/comedi/drivers/ni_daq_dio24.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,6 @@ static void dio24_detach(struct comedi_device *dev)
free_irq(dev->irq, dev);
};

struct local_info_t {
struct pcmcia_device *link;
struct bus_operations *bus;
};

static int dio24_pcmcia_config_loop(struct pcmcia_device *p_dev,
void *priv_data)
{
Expand All @@ -200,17 +195,8 @@ static int dio24_pcmcia_config_loop(struct pcmcia_device *p_dev,

static int dio24_cs_attach(struct pcmcia_device *link)
{
struct local_info_t *local;
int ret;

local = kzalloc(sizeof(*local), GFP_KERNEL);
if (!local)
return -ENOMEM;
local->link = link;
link->priv = local;

pcmcia_cur_dev = link;

link->config_flags |= CONF_ENABLE_IRQ | CONF_AUTO_AUDIO |
CONF_AUTO_SET_IO;

Expand All @@ -227,6 +213,8 @@ static int dio24_cs_attach(struct pcmcia_device *link)
if (ret)
goto failed;

pcmcia_cur_dev = link;

return 0;

failed:
Expand All @@ -237,9 +225,6 @@ static int dio24_cs_attach(struct pcmcia_device *link)
static void dio24_cs_detach(struct pcmcia_device *link)
{
pcmcia_disable_device(link);

/* This points to the parent local_info_t struct */
kfree(link->priv);
}

static const struct pcmcia_device_id dio24_cs_ids[] = {
Expand Down

0 comments on commit 1122150

Please sign in to comment.