Skip to content

Commit

Permalink
thermal: rcar: fix ENR register value
Browse files Browse the repository at this point in the history
On R-Mobile APE6, since it has 3 thermal zones, ENR register
has enable bits in bit 19-16, bit 11-8 and bit 3-0.

However, on R-Car gen2, since it has 1 thermal zone, ENR register has
enable bits in bit 3-0. (In other words, the write value should always
be 0 for bit 31-4 of ENR register.)

So, this patch fixes the ENR register value using I/O resource sets.

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
  • Loading branch information
Yoshihiro Shimoda authored and Eduardo Valentin committed Jan 7, 2015
1 parent 9477e18 commit 1131374
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions drivers/thermal/rcar_thermal.c
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
int i;
int ret = -ENODEV;
int idle = IDLE_INTERVAL;
u32 enr_bits = 0;

common = devm_kzalloc(dev, sizeof(*common), GFP_KERNEL);
if (!common)
Expand Down Expand Up @@ -408,9 +409,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
if (IS_ERR(common->base))
return PTR_ERR(common->base);

/* enable temperature comparation */
rcar_thermal_common_write(common, ENR, 0x00030303);

idle = 0; /* polling delay is not needed */
}

Expand Down Expand Up @@ -452,8 +450,15 @@ static int rcar_thermal_probe(struct platform_device *pdev)
rcar_thermal_irq_enable(priv);

list_move_tail(&priv->list, &common->head);

/* update ENR bits */
enr_bits |= 3 << (i * 8);
}

/* enable temperature comparation */
if (irq)
rcar_thermal_common_write(common, ENR, enr_bits);

platform_set_drvdata(pdev, common);

dev_info(dev, "%d sensor probed\n", i);
Expand Down

0 comments on commit 1131374

Please sign in to comment.