Skip to content

Commit

Permalink
net: cleanup vlan_features setting in register_netdev
Browse files Browse the repository at this point in the history
vlan_features contains features inherited from underlying device.
NETIF_SOFT_FEATURES are not inherited but belong to the vlan device
itself (ensured in vlan_dev_fix_features()).

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Michał Mirosław authored and David S. Miller committed Jul 14, 2011
1 parent 6c9c1b5 commit 1180e7d
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -5488,12 +5488,9 @@ int register_netdevice(struct net_device *dev)
dev->features |= NETIF_F_NOCACHE_COPY;
}

/* Enable GSO, GRO and NETIF_F_HIGHDMA for vlans by default,
* vlan_dev_fix_features() will do the features check,
* so NETIF_F_HIGHDMA feature is enabled only if supported
* by underlying device.
/* Make NETIF_F_HIGHDMA inheritable to VLAN devices.
*/
dev->vlan_features |= (NETIF_F_SOFT_FEATURES | NETIF_F_HIGHDMA);
dev->vlan_features |= NETIF_F_HIGHDMA;

ret = call_netdevice_notifiers(NETDEV_POST_INIT, dev);
ret = notifier_to_errno(ret);
Expand Down

0 comments on commit 1180e7d

Please sign in to comment.