Skip to content

Commit

Permalink
[PATCH] USB: ub 03 drop stall clearing
Browse files Browse the repository at this point in the history
Matt mentioned that a very old ZIP-100 actually does need this, but I am
yet to see anyone who actually has one still working and uses ub with it.
He/she must be a retrocomputing geek, who can easily bias it to usb-storage
with libusual, if needed. Meanwhile, common folks have trouble with poorly
designed USB keys and some el-cheapo European music players. I think we
better drop this for now.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Pete Zaitcev authored and Greg Kroah-Hartman committed Mar 20, 2006
1 parent 952ba22 commit 11a223a
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions drivers/block/ub.c
Original file line number Diff line number Diff line change
Expand Up @@ -2270,19 +2270,8 @@ static int ub_probe(struct usb_interface *intf,

nluns = 1;
for (i = 0; i < 3; i++) {
if ((rc = ub_sync_getmaxlun(sc)) < 0) {
/*
* This segment is taken from usb-storage. They say
* that ZIP-100 needs this, but my own ZIP-100 works
* fine without this.
* Still, it does not seem to hurt anything.
*/
if (rc == -EPIPE) {
ub_probe_clear_stall(sc, sc->recv_bulk_pipe);
ub_probe_clear_stall(sc, sc->send_bulk_pipe);
}
if ((rc = ub_sync_getmaxlun(sc)) < 0)
break;
}
if (rc != 0) {
nluns = rc;
break;
Expand Down

0 comments on commit 11a223a

Please sign in to comment.