Skip to content

Commit

Permalink
x86/oprofile: Add counter reservation check for virtual counters
Browse files Browse the repository at this point in the history
This patch adds a check for the availability of a counter. A virtual
counter is used only if its physical counter is not reserved.

Signed-off-by: Robert Richter <robert.richter@amd.com>
  • Loading branch information
Robert Richter committed Jul 20, 2009
1 parent 61d149d commit 11be1a7
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions arch/x86/oprofile/nmi_int.c
Original file line number Diff line number Diff line change
Expand Up @@ -435,15 +435,13 @@ static int nmi_create_files(struct super_block *sb, struct dentry *root)
struct dentry *dir;
char buf[4];

#ifndef CONFIG_OPROFILE_EVENT_MULTIPLEX
/* quick little hack to _not_ expose a counter if it is not
* available for use. This should protect userspace app.
* NOTE: assumes 1:1 mapping here (that counters are organized
* sequentially in their struct assignment).
*/
if (unlikely(!avail_to_resrv_perfctr_nmi_bit(i)))
if (!avail_to_resrv_perfctr_nmi_bit(op_x86_virt_to_phys(i)))
continue;
#endif /* CONFIG_OPROFILE_EVENT_MULTIPLEX */

snprintf(buf, sizeof(buf), "%d", i);
dir = oprofilefs_mkdir(sb, root, buf);
Expand Down

0 comments on commit 11be1a7

Please sign in to comment.