Skip to content

Commit

Permalink
staging: w35und: Inline MLMESendFrame() to wbsoft_tx()
Browse files Browse the repository at this point in the history
The wbsoft_tx() function is a simple wrapper on top of MLMESendFrame() so
inline the latter to the former.

Cc: Lars Lindley <lindley@coyote.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Pekka Enberg authored and Greg Kroah-Hartman committed Sep 21, 2010
1 parent 80a284b commit 11c9a55
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 27 deletions.
25 changes: 0 additions & 25 deletions drivers/staging/winbond/mlmetxrx.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,31 +19,6 @@

#include "mds_f.h"

#include <linux/netdevice.h>

int MLMESendFrame(struct wbsoft_priv *adapter, u8 *pMMPDU, u16 len, u8 DataType)
{
if (adapter->sMlmeFrame.IsInUsed != PACKET_FREE_TO_USE) {
adapter->sMlmeFrame.wNumTxMMPDUDiscarded++;
return NETDEV_TX_BUSY;
}
adapter->sMlmeFrame.IsInUsed = PACKET_COME_FROM_MLME;

/* Keep information for sending */
adapter->sMlmeFrame.pMMPDU = pMMPDU;
adapter->sMlmeFrame.DataType = DataType;
/* len must be the last setting due to QUERY_SIZE_SECOND of Mds */
adapter->sMlmeFrame.len = len;
adapter->sMlmeFrame.wNumTxMMPDU++;

/* H/W will enter power save by set the register. S/W don't send null frame
with PWRMgt bit enbled to enter power save now. */

Mds_Tx(adapter);

return NETDEV_TX_OK;
}

void MLME_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *desc)
{
desc->InternalUsed = desc->buffer_start_index + desc->buffer_number;
Expand Down
1 change: 0 additions & 1 deletion drivers/staging/winbond/mlmetxrx_f.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "core.h"

void MLME_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
int MLMESendFrame(struct wbsoft_priv *adapter, u8 *pMMPDU, u16 len, u8 DataType);

void
MLME_SendComplete(struct wbsoft_priv *adapter, u8 PacketID,
Expand Down
21 changes: 20 additions & 1 deletion drivers/staging/winbond/wbusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,26 @@ static int wbsoft_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
{
struct wbsoft_priv *priv = dev->priv;

return MLMESendFrame(priv, skb->data, skb->len, FRAME_TYPE_802_11_MANAGEMENT);
if (priv->sMlmeFrame.IsInUsed != PACKET_FREE_TO_USE) {
priv->sMlmeFrame.wNumTxMMPDUDiscarded++;
return NETDEV_TX_BUSY;
}

priv->sMlmeFrame.IsInUsed = PACKET_COME_FROM_MLME;

priv->sMlmeFrame.pMMPDU = skb->data;
priv->sMlmeFrame.DataType = FRAME_TYPE_802_11_MANAGEMENT;
priv->sMlmeFrame.len = skb->len;
priv->sMlmeFrame.wNumTxMMPDU++;

/*
* H/W will enter power save by set the register. S/W don't send null
* frame with PWRMgt bit enbled to enter power save now.
*/

Mds_Tx(priv);

return NETDEV_TX_OK;
}

static int wbsoft_start(struct ieee80211_hw *dev)
Expand Down

0 comments on commit 11c9a55

Please sign in to comment.