Skip to content

Commit

Permalink
Revert "xen/pv-on-hvm kexec: add xs_reset_watches to shutdown watches…
Browse files Browse the repository at this point in the history
… from old kernel"

This reverts commit ddacf5e.
As when booting the kernel under Amazon EC2 as an HVM guest it ends up
hanging during startup. Reverting this we loose the fix for kexec
booting to the crash kernels.

Fixes Canonical BZ #901305 (http://bugs.launchpad.net/bugs/901305)

Tested-by: Alessandro Salvatori <sandr8@gmail.com>
Reported-by:  Stefan Bader <stefan.bader@canonical.com>
Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Konrad Rzeszutek Wilk committed Dec 19, 2011
1 parent 63a7417 commit 12275dd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
13 changes: 0 additions & 13 deletions drivers/xen/xenbus/xenbus_xs.c
Original file line number Diff line number Diff line change
Expand Up @@ -621,15 +621,6 @@ static struct xenbus_watch *find_watch(const char *token)
return NULL;
}

static void xs_reset_watches(void)
{
int err;

err = xs_error(xs_single(XBT_NIL, XS_RESET_WATCHES, "", NULL));
if (err && err != -EEXIST)
printk(KERN_WARNING "xs_reset_watches failed: %d\n", err);
}

/* Register callback to watch this node. */
int register_xenbus_watch(struct xenbus_watch *watch)
{
Expand Down Expand Up @@ -906,9 +897,5 @@ int xs_init(void)
if (IS_ERR(task))
return PTR_ERR(task);

/* shutdown watches for kexec boot */
if (xen_hvm_domain())
xs_reset_watches();

return 0;
}
3 changes: 1 addition & 2 deletions include/xen/interface/io/xs_wire.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ enum xsd_sockmsg_type
XS_IS_DOMAIN_INTRODUCED,
XS_RESUME,
XS_SET_TARGET,
XS_RESTRICT,
XS_RESET_WATCHES
XS_RESTRICT
};

#define XS_WRITE_NONE "NONE"
Expand Down

0 comments on commit 12275dd

Please sign in to comment.