Skip to content

Commit

Permalink
affs: unobfuscate affs_fix_dcache()
Browse files Browse the repository at this point in the history
and add a comment on what it's doing

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Jul 14, 2012
1 parent 3084ee9 commit 12447c4
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions fs/affs/amigaffs.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,13 @@ affs_remove_hash(struct inode *dir, struct buffer_head *rem_bh)
}

static void
affs_fix_dcache(struct dentry *dentry, u32 entry_ino)
affs_fix_dcache(struct inode *inode, u32 entry_ino)
{
struct inode *inode = dentry->d_inode;
void *data = dentry->d_fsdata;

struct dentry *dentry;
spin_lock(&inode->i_lock);
list_for_each_entry(dentry, &inode->i_dentry, d_alias) {
if (entry_ino == (u32)(long)dentry->d_fsdata) {
dentry->d_fsdata = data;
dentry->d_fsdata = (void *)inode->i_ino;
break;
}
}
Expand Down Expand Up @@ -172,7 +170,11 @@ affs_remove_link(struct dentry *dentry)
}

affs_lock_dir(dir);
affs_fix_dcache(dentry, link_ino);
/*
* if there's a dentry for that block, make it
* refer to inode itself.
*/
affs_fix_dcache(inode, link_ino);
retval = affs_remove_hash(dir, link_bh);
if (retval) {
affs_unlock_dir(dir);
Expand Down

0 comments on commit 12447c4

Please sign in to comment.