Skip to content

Commit

Permalink
ide: remove ide_init_drive_cmd
Browse files Browse the repository at this point in the history
ide_init_drive_cmd just calls blk_rq_init. This converts the users of
ide_init_drive_cmd to use blk_rq_init directly and removes
ide_init_drive_cmd.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Borislav Petkov <petkovbb@gmail.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
FUJITA Tomonori authored and Bartlomiej Zolnierkiewicz committed Jul 15, 2008
1 parent 5f2e1ce commit 124cafc
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 23 deletions.
2 changes: 1 addition & 1 deletion drivers/ide/ide-cd.c
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void ide_cd_init_rq(ide_drive_t *drive, struct request *rq)
{
struct cdrom_info *cd = drive->driver_data;

ide_init_drive_cmd(rq);
blk_rq_init(NULL, rq);
rq->cmd_type = REQ_TYPE_ATA_PC;
rq->rq_disk = cd->disk;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/ide-floppy.c
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ static void idefloppy_queue_pc_head(ide_drive_t *drive, struct ide_atapi_pc *pc,
{
struct ide_floppy_obj *floppy = drive->driver_data;

ide_init_drive_cmd(rq);
blk_rq_init(NULL, rq);
rq->buffer = (char *) pc;
rq->cmd_type = REQ_TYPE_SPECIAL;
rq->cmd_flags |= REQ_PREEMPT;
Expand Down
17 changes: 0 additions & 17 deletions drivers/ide/ide-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -1538,23 +1538,6 @@ irqreturn_t ide_intr (int irq, void *dev_id)
return IRQ_HANDLED;
}

/**
* ide_init_drive_cmd - initialize a drive command request
* @rq: request object
*
* Initialize a request before we fill it in and send it down to
* ide_do_drive_cmd. Commands must be set up by this function. Right
* now it doesn't do a lot, but if that changes abusers will have a
* nasty surprise.
*/

void ide_init_drive_cmd (struct request *rq)
{
blk_rq_init(NULL, rq);
}

EXPORT_SYMBOL(ide_init_drive_cmd);

/**
* ide_do_drive_cmd - issue IDE special command
* @drive: device to issue command
Expand Down
4 changes: 2 additions & 2 deletions drivers/scsi/ide-scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ static int idescsi_check_condition(ide_drive_t *drive,
kfree(pc);
return -ENOMEM;
}
ide_init_drive_cmd(rq);
blk_rq_init(NULL, rq);
rq->special = (char *) pc;
pc->rq = rq;
pc->buf = buf;
Expand Down Expand Up @@ -786,7 +786,7 @@ static int idescsi_queue (struct scsi_cmnd *cmd,
}
}

ide_init_drive_cmd (rq);
blk_rq_init(NULL, rq);
rq->special = (char *) pc;
rq->cmd_type = REQ_TYPE_SPECIAL;
spin_unlock_irq(host->host_lock);
Expand Down
2 changes: 0 additions & 2 deletions include/linux/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -857,8 +857,6 @@ int ide_wait_stat(ide_startstop_t *, ide_drive_t *, u8, u8, unsigned long);

extern ide_startstop_t ide_do_reset (ide_drive_t *);

extern void ide_init_drive_cmd (struct request *rq);

/*
* "action" parameter type for ide_do_drive_cmd() below.
*/
Expand Down

0 comments on commit 124cafc

Please sign in to comment.