Skip to content

Commit

Permalink
[POWERPC] 83xx: Return a point to the struct ipic from ipic_init()
Browse files Browse the repository at this point in the history
It's useful to have access to struct ipic handle that just got created
in ipic_init().

For example, if we want to setup an external IRQ with out
a device node we need access ipic->irqhost to create the virtual to HW
IRQ mapping and to set the IRQ sense.  With this we can mimic the old
sense array concept that existed in arch/ppc.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
  • Loading branch information
Kumar Gala committed Jan 26, 2007
1 parent e60bd7f commit 126186a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
15 changes: 9 additions & 6 deletions arch/powerpc/sysdev/ipic.c
Original file line number Diff line number Diff line change
Expand Up @@ -557,16 +557,15 @@ static struct irq_host_ops ipic_host_ops = {
.xlate = ipic_host_xlate,
};

void __init ipic_init(struct device_node *node,
unsigned int flags)
struct ipic * __init ipic_init(struct device_node *node, unsigned int flags)
{
struct ipic *ipic;
struct resource res;
u32 temp = 0, ret;

ipic = alloc_bootmem(sizeof(struct ipic));
if (ipic == NULL)
return;
return NULL;

memset(ipic, 0, sizeof(struct ipic));
ipic->of_node = of_node_get(node);
Expand All @@ -576,12 +575,14 @@ void __init ipic_init(struct device_node *node,
&ipic_host_ops, 0);
if (ipic->irqhost == NULL) {
of_node_put(node);
return;
return NULL;
}

ret = of_address_to_resource(node, 0, &res);
if (ret)
return;
if (ret) {
of_node_put(node);
return NULL;
}

ipic->regs = ioremap(res.start, res.end - res.start + 1);

Expand Down Expand Up @@ -625,6 +626,8 @@ void __init ipic_init(struct device_node *node,

printk ("IPIC (%d IRQ sources) at %p\n", NR_IPIC_INTS,
primary_ipic->regs);

return ipic;
}

int ipic_set_priority(unsigned int virq, unsigned int priority)
Expand Down
2 changes: 1 addition & 1 deletion include/asm-powerpc/ipic.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ extern u32 ipic_get_mcp_status(void);
extern void ipic_clear_mcp_status(u32 mask);

#ifdef CONFIG_PPC_MERGE
extern void ipic_init(struct device_node *node, unsigned int flags);
extern struct ipic * ipic_init(struct device_node *node, unsigned int flags);
extern unsigned int ipic_get_irq(void);
#else
extern void ipic_init(phys_addr_t phys_addr, unsigned int flags,
Expand Down

0 comments on commit 126186a

Please sign in to comment.