Skip to content

Commit

Permalink
amd64_edac: fix ECC checking
Browse files Browse the repository at this point in the history
On the good path of BIOS enabled ECC and no override, the value returned
is 1 by omission and thus is deemed failing by the probe-function.

Allow proper module initialization by clearing the retval explicitly.

Signed-off-by: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
  • Loading branch information
Doug Thompson authored and Borislav Petkov committed Aug 3, 2009
1 parent ed680c4 commit 126b67b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/edac/amd64_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2977,6 +2977,9 @@ static int amd64_check_ecc_enabled(struct amd64_pvt *pvt)
"ECC is enabled by BIOS, Proceeding "
"with EDAC module initialization\n");

/* Signal good ECC status */
ret = 0;

/* CLEAR the override, since BIOS controlled it */
ecc_enable_override = 0;
}
Expand Down

0 comments on commit 126b67b

Please sign in to comment.