Skip to content

Commit

Permalink
vlan: add link to upper device
Browse files Browse the repository at this point in the history
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jiri Pirko authored and David S. Miller committed Jan 4, 2013
1 parent 7cd43db commit 126d6c2
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion net/8021q/vlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ void unregister_vlan_dev(struct net_device *dev, struct list_head *head)
*/
unregister_netdevice_queue(dev, head);

netdev_upper_dev_unlink(real_dev, dev);

if (grp->nr_vlan_devs == 0)
vlan_gvrp_uninit_applicant(real_dev);

Expand Down Expand Up @@ -162,9 +164,13 @@ int register_vlan_dev(struct net_device *dev)
if (err < 0)
goto out_uninit_applicant;

err = netdev_upper_dev_link(real_dev, dev);
if (err)
goto out_uninit_applicant;

err = register_netdevice(dev);
if (err < 0)
goto out_uninit_applicant;
goto out_upper_dev_unlink;

/* Account for reference in struct vlan_dev_priv */
dev_hold(real_dev);
Expand All @@ -180,6 +186,8 @@ int register_vlan_dev(struct net_device *dev)

return 0;

out_upper_dev_unlink:
netdev_upper_dev_unlink(real_dev, dev);
out_uninit_applicant:
if (grp->nr_vlan_devs == 0)
vlan_gvrp_uninit_applicant(real_dev);
Expand Down

0 comments on commit 126d6c2

Please sign in to comment.