Skip to content

Commit

Permalink
usb: gadget: amd5536udc: let udc-core manage gadget->dev
Browse files Browse the repository at this point in the history
By simply setting a flag, we drop some boilerplate
code.

Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Felipe Balbi committed Mar 18, 2013
1 parent 6dfc84f commit 12ad0fc
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions drivers/usb/gadget/amd5536udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -3080,7 +3080,6 @@ static void udc_pci_remove(struct pci_dev *pdev)
if (dev->active)
pci_disable_device(pdev);

device_unregister(&dev->gadget.dev);
pci_set_drvdata(pdev, NULL);

udc_remove(dev);
Expand Down Expand Up @@ -3276,6 +3275,7 @@ static int udc_probe(struct udc *dev)
dev->gadget.dev.release = gadget_release;
dev->gadget.name = name;
dev->gadget.max_speed = USB_SPEED_HIGH;
dev->gadget.register_my_device = true;

/* init registers, interrupts, ... */
startup_registers(dev);
Expand All @@ -3301,13 +3301,6 @@ static int udc_probe(struct udc *dev)
if (retval)
goto finished;

retval = device_register(&dev->gadget.dev);
if (retval) {
usb_del_gadget_udc(&dev->gadget);
put_device(&dev->gadget.dev);
goto finished;
}

/* timer init */
init_timer(&udc_timer);
udc_timer.function = udc_timer_function;
Expand Down

0 comments on commit 12ad0fc

Please sign in to comment.