Skip to content

Commit

Permalink
[PKTGEN]: Fix kernel_thread() fail leak.
Browse files Browse the repository at this point in the history
Free all the alocated resources if kernel_thread() call fails.

Signed-off-by: Luiz Capitulino <lcapitulino@mandriva.com.br>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Luiz Capitulino authored and David S. Miller committed Mar 21, 2006
1 parent cdcdbe0 commit 12e1872
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions net/core/pktgen.c
Original file line number Diff line number Diff line change
Expand Up @@ -3082,6 +3082,7 @@ static struct pktgen_thread *__init pktgen_find_thread(const char *name)

static int __init pktgen_create_thread(const char *name, int cpu)
{
int err;
struct pktgen_thread *t = NULL;
struct proc_dir_entry *pe;

Expand Down Expand Up @@ -3120,9 +3121,15 @@ static int __init pktgen_create_thread(const char *name, int cpu)

t->removed = 0;

if (kernel_thread((void *)pktgen_thread_worker, (void *)t,
CLONE_FS | CLONE_FILES | CLONE_SIGHAND) < 0)
err = kernel_thread((void *)pktgen_thread_worker, (void *)t,
CLONE_FS | CLONE_FILES | CLONE_SIGHAND);
if (err < 0) {
printk("pktgen: kernel_thread() failed for cpu %d\n", t->cpu);
remove_proc_entry(t->name, pg_proc_dir);
list_del(&t->th_list);
kfree(t);
return err;
}

return 0;
}
Expand Down

0 comments on commit 12e1872

Please sign in to comment.