Skip to content

Commit

Permalink
Staging: ipack/devices/ipoctal: fix dereference NULL pointer
Browse files Browse the repository at this point in the history
After opening and closing the file /dev/ipoctal.X.Y.Z for the second time, it
gives a kernel oops due to a dereference of a NULL pointer.

The problem was that tty->driver_data was not properly initialized when
accessing the file for the second time.

Reported-by: Alberto Garcia Gonzalez <agarcia@igalia.com>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Samuel Iglesias Gonsálvez authored and Greg Kroah-Hartman committed Jul 17, 2012
1 parent d254eb7 commit 1337b07
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/ipack/devices/ipoctal.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ static int ipoctal_port_activate(struct tty_port *port, struct tty_struct *tty)

ipoctal_write_io_reg(ipoctal, &ipoctal->chan_regs[channel].u.w.cr,
CR_ENABLE_RX);
tty->driver_data = ipoctal;

return 0;
}

Expand All @@ -136,6 +134,8 @@ static int ipoctal_open(struct tty_struct *tty, struct file *file)
if (atomic_read(&ipoctal->open[channel]))
return -EBUSY;

tty->driver_data = ipoctal;

res = tty_port_open(&ipoctal->tty_port[channel], tty, file);
if (res)
return res;
Expand Down

0 comments on commit 1337b07

Please sign in to comment.