Skip to content

Commit

Permalink
[ARM] ecard: convert to use the kthread API
Browse files Browse the repository at this point in the history
This patch modifies the startup of kecardd to use kthread_run not a
kernel_thread combination of kernel_thread and daemonize.  Making the code
slightly simpler and more maintainable.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Eric W. Biederman authored and Russell King committed May 3, 2007
1 parent 73b6a2b commit 134c99e
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions arch/arm/kernel/ecard.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include <linux/device.h>
#include <linux/init.h>
#include <linux/mutex.h>
#include <linux/kthread.h>

#include <asm/dma.h>
#include <asm/ecard.h>
Expand Down Expand Up @@ -263,8 +264,6 @@ static int ecard_init_mm(void)
static int
ecard_task(void * unused)
{
daemonize("kecardd");

/*
* Allocate a mm. We're not a lazy-TLB kernel task since we need
* to set page table entries where the user space would be. Note
Expand Down Expand Up @@ -1059,13 +1058,14 @@ ecard_probe(int slot, card_type_t type)
*/
static int __init ecard_init(void)
{
int slot, irqhw, ret;
struct task_struct *task;
int slot, irqhw;

ret = kernel_thread(ecard_task, NULL, CLONE_KERNEL);
if (ret < 0) {
task = kthread_run(ecard_task, NULL, "kecardd");
if (IS_ERR(task)) {
printk(KERN_ERR "Ecard: unable to create kernel thread: %d\n",
ret);
return ret;
PTR_ERR(task));
return PTR_ERR(task);
}

printk("Probing expansion cards\n");
Expand Down

0 comments on commit 134c99e

Please sign in to comment.