Skip to content

Commit

Permalink
x86: convert some existing cpuid disable options to new generic bitmap
Browse files Browse the repository at this point in the history
This convers nofxsr, mem=nopentium and nosep to use the new
generic cpuid disable bitmap instead of using own variables.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Andi Kleen authored and Ingo Molnar committed Jan 30, 2008
1 parent 7d851c8 commit 1353025
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 34 deletions.
34 changes: 4 additions & 30 deletions arch/x86/kernel/cpu/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,10 @@ EXPORT_PER_CPU_SYMBOL_GPL(gdt_page);
__u32 cleared_cpu_caps[NCAPINTS] __cpuinitdata;

static int cachesize_override __cpuinitdata = -1;
static int disable_x86_fxsr __cpuinitdata;
static int disable_x86_serial_nr __cpuinitdata = 1;
static int disable_x86_sep __cpuinitdata;

struct cpu_dev * cpu_devs[X86_VENDOR_NUM] = {};

extern int disable_pse;

static void __cpuinit default_init(struct cpuinfo_x86 * c)
{
/* Not much we can do here... */
Expand Down Expand Up @@ -216,24 +212,16 @@ static void __cpuinit get_cpu_vendor(struct cpuinfo_x86 *c, int early)

static int __init x86_fxsr_setup(char * s)
{
/* Tell all the other CPUs to not use it... */
disable_x86_fxsr = 1;

/*
* ... and clear the bits early in the boot_cpu_data
* so that the bootup process doesn't try to do this
* either.
*/
clear_bit(X86_FEATURE_FXSR, boot_cpu_data.x86_capability);
clear_bit(X86_FEATURE_XMM, boot_cpu_data.x86_capability);
setup_clear_cpu_cap(X86_FEATURE_FXSR);
setup_clear_cpu_cap(X86_FEATURE_XMM);
return 1;
}
__setup("nofxsr", x86_fxsr_setup);


static int __init x86_sep_setup(char * s)
{
disable_x86_sep = 1;
setup_clear_cpu_cap(X86_FEATURE_SEP);
return 1;
}
__setup("nosep", x86_sep_setup);
Expand Down Expand Up @@ -462,19 +450,6 @@ void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
if ( tsc_disable )
clear_bit(X86_FEATURE_TSC, c->x86_capability);

/* FXSR disabled? */
if (disable_x86_fxsr) {
clear_bit(X86_FEATURE_FXSR, c->x86_capability);
clear_bit(X86_FEATURE_XMM, c->x86_capability);
}

/* SEP disabled? */
if (disable_x86_sep)
clear_bit(X86_FEATURE_SEP, c->x86_capability);

if (disable_pse)
clear_bit(X86_FEATURE_PSE, c->x86_capability);

/* If the model name is still unset, do table lookup. */
if ( !c->x86_model_id[0] ) {
char *p;
Expand Down Expand Up @@ -629,8 +604,7 @@ void __init early_cpu_init(void)
/* pse is not compatible with on-the-fly unmapping,
* disable it even if the cpus claim to support it.
*/
clear_bit(X86_FEATURE_PSE, boot_cpu_data.x86_capability);
disable_pse = 1;
setup_clear_cpu_cap(X86_FEATURE_PSE);
#endif
}

Expand Down
5 changes: 1 addition & 4 deletions arch/x86/kernel/setup_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@
address, and must not be in the .bss segment! */
unsigned long init_pg_tables_end __initdata = ~0UL;

int disable_pse __cpuinitdata = 0;

/*
* Machine setup..
*/
Expand Down Expand Up @@ -242,8 +240,7 @@ static int __init parse_mem(char *arg)
return -EINVAL;

if (strcmp(arg, "nopentium") == 0) {
clear_cpu_cap(&boot_cpu_data, X86_FEATURE_PSE);
disable_pse = 1;
setup_clear_cpu_cap(X86_FEATURE_PSE);
} else {
/* If the user specifies memory size, we
* limit the BIOS-provided memory map to
Expand Down

0 comments on commit 1353025

Please sign in to comment.