Skip to content

Commit

Permalink
Btrfs: don't try to commit in btrfs_block_rsv_check
Browse files Browse the repository at this point in the history
We will try and reserve metadata bytes in btrfs_block_rsv_check and if we cannot
because we have a transaction open it will return EAGAIN, so we do not need to
try and commit the transaction again.

Signed-off-by: Josef Bacik <josef@redhat.com>
  • Loading branch information
Josef Bacik committed Oct 19, 2011
1 parent dabdb64 commit 13553e5
Showing 1 changed file with 4 additions and 25 deletions.
29 changes: 4 additions & 25 deletions fs/btrfs/extent-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -3708,7 +3708,6 @@ int btrfs_block_rsv_check(struct btrfs_trans_handle *trans,
u64 min_reserved, int min_factor)
{
u64 num_bytes = 0;
int commit_trans = 0;
int ret = -ENOSPC;

if (!block_rsv)
Expand All @@ -3720,13 +3719,12 @@ int btrfs_block_rsv_check(struct btrfs_trans_handle *trans,
if (min_reserved > num_bytes)
num_bytes = min_reserved;

if (block_rsv->reserved >= num_bytes) {
if (block_rsv->reserved >= num_bytes)
ret = 0;
} else {
else
num_bytes -= block_rsv->reserved;
commit_trans = 1;
}
spin_unlock(&block_rsv->lock);

if (!ret)
return 0;

Expand All @@ -3736,26 +3734,7 @@ int btrfs_block_rsv_check(struct btrfs_trans_handle *trans,
return 0;
}

if (commit_trans) {
struct btrfs_space_info *sinfo = block_rsv->space_info;

if (trans)
return -EAGAIN;

spin_lock(&sinfo->lock);
if (sinfo->bytes_pinned < num_bytes) {
spin_unlock(&sinfo->lock);
return -ENOSPC;
}
spin_unlock(&sinfo->lock);

trans = btrfs_join_transaction(root);
BUG_ON(IS_ERR(trans));
ret = btrfs_commit_transaction(trans, root);
return 0;
}

return -ENOSPC;
return ret;
}

int btrfs_block_rsv_migrate(struct btrfs_block_rsv *src_rsv,
Expand Down

0 comments on commit 13553e5

Please sign in to comment.