Skip to content

Commit

Permalink
[PATCH] don't select CONFIG_HOTPLUG
Browse files Browse the repository at this point in the history
It's useful to be able to turn off CONFIG_HOTPLUG for compile-coverage testing
and for section-checking coverage.  But a few things go and select
CONFIG_HOTPLUG, making it a royal PITA to turn the thing off.

It's only turnable offable if CONFIG_EMBEDDED anyway.  So let's make those
things depend on HOTPLUG, not select it.

Cc: Greg KH <greg@kroah.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andrew Morton authored and Linus Torvalds committed Jul 10, 2006
1 parent b3cf257 commit 135c294
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/base/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ config PREVENT_FIRMWARE_BUILD

config FW_LOADER
tristate "Userspace firmware loading support"
select HOTPLUG
depends on HOTPLUG
---help---
This option is provided for the case where no in-kernel-tree modules
require userspace firmware loading support, but a module built outside
Expand Down
3 changes: 1 addition & 2 deletions drivers/pci/hotplug/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ menu "PCI Hotplug Support"

config HOTPLUG_PCI
tristate "Support for PCI Hotplug (EXPERIMENTAL)"
depends on PCI && EXPERIMENTAL
select HOTPLUG
depends on PCI && EXPERIMENTAL && HOTPLUG
---help---
Say Y here if you have a motherboard with a PCI Hotplug controller.
This allows you to add and remove PCI cards while the machine is
Expand Down
2 changes: 1 addition & 1 deletion drivers/pcmcia/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ menu "PCCARD (PCMCIA/CardBus) support"

config PCCARD
tristate "PCCard (PCMCIA/CardBus) support"
select HOTPLUG
depends on HOTPLUG
---help---
Say Y here if you want to attach PCMCIA- or PC-cards to your Linux
computer. These are credit-card size devices such as network cards,
Expand Down

0 comments on commit 135c294

Please sign in to comment.