Skip to content

Commit

Permalink
leds: Use setup_timer
Browse files Browse the repository at this point in the history
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression t,f,d;
@@

-init_timer(&t);
+setup_timer(&t,f,d);
-t.function = f;
-t.data = d;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
  • Loading branch information
Julia Lawall authored and Bryan Wu committed Jan 14, 2015
1 parent 56d06fd commit 137fe48
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/leds/led-class.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,8 @@ int led_classdev_register(struct device *parent, struct led_classdev *led_cdev)

INIT_WORK(&led_cdev->set_brightness_work, set_brightness_delayed);

init_timer(&led_cdev->blink_timer);
led_cdev->blink_timer.function = led_timer_function;
led_cdev->blink_timer.data = (unsigned long)led_cdev;
setup_timer(&led_cdev->blink_timer, led_timer_function,
(unsigned long)led_cdev);

#ifdef CONFIG_LEDS_TRIGGERS
led_trigger_set_default(led_cdev);
Expand Down

0 comments on commit 137fe48

Please sign in to comment.