Skip to content

Commit

Permalink
bcache: Fix a flush/fua performance bug
Browse files Browse the repository at this point in the history
bch_journal_meta() was missing the flush to make the journal write
actually go down (instead of waiting up to journal_delay_ms)...

Whoops

Signed-off-by: Kent Overstreet <kmo@daterainc.com>
Cc: linux-stable <stable@vger.kernel.org> # >= v3.10
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Kent Overstreet authored and Linus Torvalds committed Sep 24, 2013
1 parent c2a4f31 commit 1394d67
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/md/bcache/journal.c
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,7 @@ void bch_journal_meta(struct cache_set *c, struct closure *cl)
if (cl)
BUG_ON(!closure_wait(&w->wait, cl));

closure_flush(&c->journal.io);
__journal_try_write(c, true);
}
}
Expand Down

0 comments on commit 1394d67

Please sign in to comment.