Skip to content

Commit

Permalink
[NETFILTER]: xt_pkttype: Add explicit check for IPv4
Browse files Browse the repository at this point in the history
In the PACKET_LOOPBACK case, the skb data was always interpreted as
IPv4, but that is not valid for IPv6, obviously. Fix this by adding an
extra condition to check for AF_INET.

Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jan Engelhardt authored and David S. Miller committed Jan 28, 2008
1 parent 17b0d7e commit 13b0e83
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/netfilter/xt_pkttype.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ pkttype_mt(const struct sk_buff *skb, const struct net_device *in,
const struct xt_pkttype_info *info = matchinfo;

if (skb->pkt_type == PACKET_LOOPBACK)
type = ipv4_is_multicast(ip_hdr(skb)->daddr)
type = match->family == AF_INET &&
ipv4_is_multicast(ip_hdr(skb)->daddr)
? PACKET_MULTICAST
: PACKET_BROADCAST;
else
Expand Down

0 comments on commit 13b0e83

Please sign in to comment.