Skip to content

Commit

Permalink
staging: vt6655: do not use PCI resources before pci_enable_device()
Browse files Browse the repository at this point in the history
IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.

The semantic match that finds this problem is as follows:

// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@

(
* x->irq
|
* x->resource
|
* request(x, ...)
)
 ...
*pci_enable_device(x)
// </smpl>

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Kulikov Vasiliy authored and Greg Kroah-Hartman committed Aug 31, 2010
1 parent bd2bc4c commit 13b631a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/staging/vt6655/device_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -955,12 +955,13 @@ vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent)
pDevice->dev = dev;
pDevice->next_module = root_device_dev;
root_device_dev = dev;
dev->irq = pcid->irq;

if (pci_enable_device(pcid)) {
device_free_info(pDevice);
return -ENODEV;
}
dev->irq = pcid->irq;

#ifdef DEBUG
printk("Before get pci_info memaddr is %x\n",pDevice->memaddr);
#endif
Expand Down

0 comments on commit 13b631a

Please sign in to comment.