Skip to content

Commit

Permalink
v4l: copy_to_user() is not a good method name
Browse files Browse the repository at this point in the history
Breaks on any target that has copy_to_user() defined as a non-trivial
macro.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Al Viro authored and Linus Torvalds committed Oct 13, 2007
1 parent 2b8232c commit 13bcd5d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/media/video/videobuf-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ ssize_t videobuf_read_one(struct videobuf_queue *q,
}

/* Copy to userspace */
retval=CALL(q,copy_to_user,q,data,count,nonblocking);
retval=CALL(q,video_copy_to_user,q,data,count,nonblocking);
if (retval<0)
goto done;

Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/videobuf-dma-sg.c
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ static struct videobuf_qtype_ops pci_ops = {
.sync = __videobuf_sync,
.mmap_free = __videobuf_mmap_free,
.mmap_mapper = __videobuf_mmap_mapper,
.copy_to_user = __videobuf_copy_to_user,
.video_copy_to_user = __videobuf_copy_to_user,
.copy_stream = __videobuf_copy_stream,
};

Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/videobuf-vmalloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ static struct videobuf_qtype_ops qops = {
.sync = __videobuf_sync,
.mmap_free = __videobuf_mmap_free,
.mmap_mapper = __videobuf_mmap_mapper,
.copy_to_user = __videobuf_copy_to_user,
.video_copy_to_user = __videobuf_copy_to_user,
.copy_stream = __videobuf_copy_stream,
};

Expand Down
2 changes: 1 addition & 1 deletion include/media/videobuf-core.h
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ struct videobuf_qtype_ops {
enum v4l2_memory memory);
int (*sync) (struct videobuf_queue* q,
struct videobuf_buffer *buf);
int (*copy_to_user) (struct videobuf_queue *q,
int (*video_copy_to_user)(struct videobuf_queue *q,
char __user *data,
size_t count,
int nonblocking);
Expand Down

0 comments on commit 13bcd5d

Please sign in to comment.