Skip to content

Commit

Permalink
USB: input: bcm5974.c: fix up dev_err() usage
Browse files Browse the repository at this point in the history
We should always reference the input device for dev_err(), not the USB
device.  Fix up the places where I got this wrong.

Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Henrik Rydberg <rydberg@euromail.se>
CC: Alessandro Rubini <rubini@ipvvis.unipv.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed May 2, 2012
1 parent 80f8594 commit 140b123
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/input/mouse/bcm5974.c
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
int retval = 0, size;

if (!data) {
dev_err(&dev->intf->dev, "out of memory\n");
dev_err(&dev->input->dev, "out of memory\n");
retval = -ENOMEM;
goto out;
}
Expand All @@ -597,7 +597,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
BCM5974_WELLSPRING_MODE_REQUEST_INDEX, data, 8, 5000);

if (size != 8) {
dev_err(&dev->intf->dev, "could not read from device\n");
dev_err(&dev->input->dev, "could not read from device\n");
retval = -EIO;
goto out;
}
Expand All @@ -615,7 +615,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
BCM5974_WELLSPRING_MODE_REQUEST_INDEX, data, 8, 5000);

if (size != 8) {
dev_err(&dev->intf->dev, "could not write to device\n");
dev_err(&dev->input->dev, "could not write to device\n");
retval = -EIO;
goto out;
}
Expand Down Expand Up @@ -654,7 +654,7 @@ static void bcm5974_irq_button(struct urb *urb)
exit:
error = usb_submit_urb(dev->bt_urb, GFP_ATOMIC);
if (error)
dev_err(&dev->intf->dev, "button urb failed: %d\n", error);
dev_err(&dev->input->dev, "button urb failed: %d\n", error);
}

static void bcm5974_irq_trackpad(struct urb *urb)
Expand Down Expand Up @@ -687,7 +687,7 @@ static void bcm5974_irq_trackpad(struct urb *urb)
exit:
error = usb_submit_urb(dev->tp_urb, GFP_ATOMIC);
if (error)
dev_err(&dev->intf->dev, "trackpad urb failed: %d\n", error);
dev_err(&dev->input->dev, "trackpad urb failed: %d\n", error);
}

/*
Expand Down

0 comments on commit 140b123

Please sign in to comment.