Skip to content

Commit

Permalink
ide: initialize rq->cmd_type in ide_init_drive_cmd() callers
Browse files Browse the repository at this point in the history
* Initialize rq->cmd_type in ide_wait_cmd(), ide_cmd_ioctl() and
  set_pio_mode() (other callers were aleady over-riding rq->cmd_type).

* Remove no longer needed rq->cmd_type setup from ide_init_drive_cmd().

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Jan 26, 2008
1 parent 2624565 commit 145b75e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/ide/ide-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -1672,7 +1672,6 @@ irqreturn_t ide_intr (int irq, void *dev_id)
void ide_init_drive_cmd (struct request *rq)
{
memset(rq, 0, sizeof(*rq));
rq->cmd_type = REQ_TYPE_ATA_CMD;
rq->ref_count = 1;
}

Expand Down
4 changes: 4 additions & 0 deletions drivers/ide/ide-taskfile.c
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,7 @@ int ide_wait_cmd (ide_drive_t *drive, u8 cmd, u8 nsect, u8 feature, u8 sectors,
buf = buffer;
memset(buf, 0, 4 + SECTOR_WORDS * 4 * sectors);
ide_init_drive_cmd(&rq);
rq.cmd_type = REQ_TYPE_ATA_CMD;
rq.buffer = buf;
*buf++ = cmd;
*buf++ = nsect;
Expand All @@ -778,7 +779,10 @@ int ide_cmd_ioctl (ide_drive_t *drive, unsigned int cmd, unsigned long arg)

if (NULL == (void *) arg) {
struct request rq;

ide_init_drive_cmd(&rq);
rq.cmd_type = REQ_TYPE_ATA_CMD;

return ide_do_drive_cmd(drive, &rq, ide_wait);
}

Expand Down
3 changes: 3 additions & 0 deletions drivers/ide/ide.c
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,10 @@ int set_pio_mode(ide_drive_t *drive, int arg)

if (drive->special.b.set_tune)
return -EBUSY;

ide_init_drive_cmd(&rq);
rq.cmd_type = REQ_TYPE_ATA_CMD;

drive->tune_req = (u8) arg;
drive->special.b.set_tune = 1;
(void) ide_do_drive_cmd(drive, &rq, ide_wait);
Expand Down

0 comments on commit 145b75e

Please sign in to comment.