Skip to content

Commit

Permalink
fat: simplify writeback_inode()
Browse files Browse the repository at this point in the history
[akpm@linux-foundation.org: checkpatch fixes]
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Namjae Jeon authored and Linus Torvalds committed Oct 5, 2012
1 parent 126ac05 commit 1486465
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions fs/fat/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -1463,18 +1463,14 @@ static int writeback_inode(struct inode *inode)
{

int ret;
struct address_space *mapping = inode->i_mapping;
struct writeback_control wbc = {
.sync_mode = WB_SYNC_NONE,
.nr_to_write = 0,
};
/* if we used WB_SYNC_ALL, sync_inode waits for the io for the
* inode to finish. So WB_SYNC_NONE is sent down to sync_inode

/* if we used wait=1, sync_inode_metadata waits for the io for the
* inode to finish. So wait=0 is sent down to sync_inode_metadata
* and filemap_fdatawrite is used for the data blocks
*/
ret = sync_inode(inode, &wbc);
ret = sync_inode_metadata(inode, 0);
if (!ret)
ret = filemap_fdatawrite(mapping);
ret = filemap_fdatawrite(inode->i_mapping);
return ret;
}

Expand Down

0 comments on commit 1486465

Please sign in to comment.