gen_stats: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error prone and make code hard to audit. Signed-off-by: David S. Miller <davem@davemloft.net>
git-mirror · Apr 2, 2012 · 14ad664 · 14ad664
1 parent 0e3cea7
commit 14ad664
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c
@@ -27,7 +27,8 @@
 static inline int
 gnet_stats_copy(struct gnet_dump *d, int type, void *buf, int size)
 {
-	NLA_PUT(d->skb, type, size, buf);
+	if (nla_put(d->skb, type, size, buf))
+		goto nla_put_failure;
 	return 0;
 
 nla_put_failure: