Skip to content

Commit

Permalink
sched/cpuacct: Initialize root cpuacct earlier
Browse files Browse the repository at this point in the history
Now we don't need cpuacct_init(), and instead we just initialize
root_cpuacct when it's defined.

Signed-off-by: Li Zefan <lizefan@huawei.com>
Cc: Tejun Heo <tj@kernel.org>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/51553834.9090701@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Li Zefan authored and Ingo Molnar committed Apr 10, 2013
1 parent 7943e15 commit 14c6d3c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 14 deletions.
2 changes: 0 additions & 2 deletions kernel/sched/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -6936,8 +6936,6 @@ void __init sched_init(void)

#endif /* CONFIG_CGROUP_SCHED */

cpuacct_init();

for_each_possible_cpu(i) {
struct rq *rq;

Expand Down
11 changes: 4 additions & 7 deletions kernel/sched/cpuacct.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ static inline struct cpuacct *parent_ca(struct cpuacct *ca)
}

static DEFINE_PER_CPU(u64, root_cpuacct_cpuusage);
static struct cpuacct root_cpuacct;
static struct cpuacct root_cpuacct = {
.cpustat = &kernel_cpustat,
.cpuusage = &root_cpuacct_cpuusage,
};

/* create a new cpu accounting group */
static struct cgroup_subsys_state *cpuacct_css_alloc(struct cgroup *cgrp)
Expand Down Expand Up @@ -288,12 +291,6 @@ void cpuacct_account_field(struct task_struct *p, int index, u64 val)
rcu_read_unlock();
}

void __init cpuacct_init(void)
{
root_cpuacct.cpustat = &kernel_cpustat;
root_cpuacct.cpuusage = &root_cpuacct_cpuusage;
}

struct cgroup_subsys cpuacct_subsys = {
.name = "cpuacct",
.css_alloc = cpuacct_css_alloc,
Expand Down
5 changes: 0 additions & 5 deletions kernel/sched/cpuacct.h
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
#ifdef CONFIG_CGROUP_CPUACCT

extern void cpuacct_init(void);
extern void cpuacct_charge(struct task_struct *tsk, u64 cputime);
extern void cpuacct_account_field(struct task_struct *p, int index, u64 val);

#else

static inline void cpuacct_init(void)
{
}

static inline void cpuacct_charge(struct task_struct *tsk, u64 cputime)
{
}
Expand Down

0 comments on commit 14c6d3c

Please sign in to comment.