Skip to content

Commit

Permalink
ASoC: pcm512x: Remove hardcoding of pll-lock to GPIO4
Browse files Browse the repository at this point in the history
Currently GPIO4 is hardcoded to output the pll-lock signal.
Unfortunately this is after the pll-out GPIO is configured which
is selectable in the device tree. Therefore it is not possible to
use GPIO4 for pll-out. Therefore this patch removes the
configuration of GPIO4.

Signed-off-by: Howard Mitchell <hm@hmbedded.co.uk>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Howard Mitchell authored and Mark Brown committed Apr 11, 2015
1 parent c517d83 commit 14f0413
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions sound/soc/codecs/pcm512x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1156,25 +1156,6 @@ static int pcm512x_hw_params(struct snd_pcm_substream *substream,
ret, pcm512x->pll_out);
return ret;
}

gpio = PCM512x_G1OE << (4 - 1);
ret = regmap_update_bits(pcm512x->regmap, PCM512x_GPIO_EN,
gpio, gpio);
if (ret != 0) {
dev_err(codec->dev, "Failed to enable gpio %d: %d\n",
4, ret);
return ret;
}

gpio = PCM512x_GPIO_OUTPUT_1 + 4 - 1;
ret = regmap_update_bits(pcm512x->regmap, gpio,
PCM512x_GxSL, PCM512x_GxSL_PLLLK);
if (ret != 0) {
dev_err(codec->dev,
"Failed to output pll lock on %d: %d\n",
ret, 4);
return ret;
}
}

ret = regmap_update_bits(pcm512x->regmap, PCM512x_SYNCHRONIZE,
Expand Down

0 comments on commit 14f0413

Please sign in to comment.