Skip to content

Commit

Permalink
[PATCH] via82cxxx_audio: Use pci_get_device
Browse files Browse the repository at this point in the history
pci_find_device is not refcounting and should be getting killed off.

Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Alan Cox authored and Linus Torvalds committed Oct 1, 2006
1 parent f2443ab commit 14fef64
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions sound/oss/via82cxxx_audio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1547,7 +1547,7 @@ static int via_mixer_open (struct inode *inode, struct file *file)

DPRINTK ("ENTER\n");

while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) {
while ((pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) {
drvr = pci_dev_driver (pdev);
if (drvr == &via_driver) {
assert (pci_get_drvdata (pdev) != NULL);
Expand All @@ -1562,6 +1562,7 @@ static int via_mixer_open (struct inode *inode, struct file *file)
return -ENODEV;

match:
pci_dev_put(pdev);
file->private_data = card->ac97;

DPRINTK ("EXIT, returning 0\n");
Expand Down Expand Up @@ -3245,7 +3246,7 @@ static int via_dsp_open (struct inode *inode, struct file *file)
}

card = NULL;
while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) {
while ((pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) {
drvr = pci_dev_driver (pdev);
if (drvr == &via_driver) {
assert (pci_get_drvdata (pdev) != NULL);
Expand All @@ -3264,6 +3265,7 @@ static int via_dsp_open (struct inode *inode, struct file *file)
return -ENODEV;

match:
pci_dev_put(pdev);
if (nonblock) {
if (!mutex_trylock(&card->open_mutex)) {
DPRINTK ("EXIT, returning -EAGAIN\n");
Expand Down

0 comments on commit 14fef64

Please sign in to comment.