Skip to content

Commit

Permalink
[PATCH] x86_64: Use X86_FEATURE_CONSTANT_TSC now to clean up Intel sp…
Browse files Browse the repository at this point in the history
…eedstep drivers

They previously tried to figure this out on their own.

Suggested by Venkatesh.

Cc: venkatesh.pallipadi@intel.com
Cc: davej@redhat.com
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Jan 12, 2006
1 parent 39b3a79 commit 152bf8c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 31 deletions.
5 changes: 2 additions & 3 deletions arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@
#include <linux/acpi.h>
#include <acpi/processor.h>

#include "speedstep-est-common.h"

#define dprintk(msg...) cpufreq_debug_printk(CPUFREQ_DEBUG_DRIVER, "acpi-cpufreq", msg)

MODULE_AUTHOR("Paul Diefenbaugh, Dominik Brodowski");
Expand Down Expand Up @@ -367,6 +365,7 @@ acpi_cpufreq_cpu_init (
unsigned int cpu = policy->cpu;
struct cpufreq_acpi_io *data;
unsigned int result = 0;
struct cpuinfo_x86 *c = &cpu_data[policy->cpu];

union acpi_object arg0 = {ACPI_TYPE_BUFFER};
u32 arg0_buf[3];
Expand All @@ -390,7 +389,7 @@ acpi_cpufreq_cpu_init (
if (result)
goto err_free;

if (is_const_loops_cpu(cpu)) {
if (cpu_has(c, X86_FEATURE_CONSTANT_TSC)) {
acpi_cpufreq_driver.flags |= CPUFREQ_CONST_LOOPS;
}

Expand Down
5 changes: 2 additions & 3 deletions arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
#include <asm/processor.h>
#include <asm/cpufeature.h>

#include "speedstep-est-common.h"

#define PFX "speedstep-centrino: "
#define MAINTAINER "Jeremy Fitzhardinge <jeremy@goop.org>"

Expand Down Expand Up @@ -493,12 +491,13 @@ static int centrino_cpu_init(struct cpufreq_policy *policy)
unsigned l, h;
int ret;
int i;
struct cpuinfo_x86 *c = &cpu_data[policy->cpu];

/* Only Intel makes Enhanced Speedstep-capable CPUs */
if (cpu->x86_vendor != X86_VENDOR_INTEL || !cpu_has(cpu, X86_FEATURE_EST))
return -ENODEV;

if (is_const_loops_cpu(policy->cpu)) {
if (cpu_has(c, X86_FEATURE_CONSTANT_TSC)) {
centrino_driver.flags |= CPUFREQ_CONST_LOOPS;
}

Expand Down
25 changes: 0 additions & 25 deletions arch/i386/kernel/cpu/cpufreq/speedstep-est-common.h

This file was deleted.

0 comments on commit 152bf8c

Please sign in to comment.