Skip to content

Commit

Permalink
OMAP2+: clockdomain: move header file from plat-omap to mach-omap2
Browse files Browse the repository at this point in the history
The OMAP clockdomain code and data is all OMAP2+-specific.  This seems
unlikely to change any time soon.  Move plat-omap/include/plat/clockdomain.h
to mach-omap2/clockdomain.h.  The primary point of doing this is to remove
the temptation for unrelated upper-layer code to access clockdomain code
and data directly.

DSPBridge also uses the clockdomain headers for some reason, so,
modify it also. The DSPBridge code should not be including the
clockdomain headers; these should be removed.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Omar Ramirez Luna <omar.ramirez@ti.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>
Tested-by: Rajendra Nayak <rnayak@ti.com>
Tested-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
  • Loading branch information
Paul Walmsley committed Dec 22, 2010
1 parent 55ae350 commit 1540f21
Show file tree
Hide file tree
Showing 14 changed files with 20 additions and 17 deletions.
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#include <linux/bitops.h>

#include <plat/clock.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"
#include <plat/cpu.h>
#include <plat/prcm.h>

Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/clockdomain.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

#include <plat/clock.h>
#include <plat/powerdomain.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"
#include <plat/prcm.h>

/* clkdm_list contains all registered struct clockdomains */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,10 @@
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*
* XXX This should be moved to mach-omap2/ at the earliest opportunity.
*/

#ifndef __ASM_ARM_ARCH_OMAP_CLOCKDOMAIN_H
#define __ASM_ARM_ARCH_OMAP_CLOCKDOMAIN_H
#ifndef __ARCH_ARM_MACH_OMAP2_CLOCKDOMAIN_H
#define __ARCH_ARM_MACH_OMAP2_CLOCKDOMAIN_H

#include <linux/init.h>

Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/clockdomains2xxx_3xxx_data.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#include <linux/kernel.h>
#include <linux/io.h>

#include <plat/clockdomain.h>
#include "clockdomain.h"
#include "prm2xxx_3xxx.h"
#include "cm2xxx_3xxx.h"
#include "cm-regbits-24xx.h"
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/clockdomains44xx_data.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
#include <linux/kernel.h>
#include <linux/io.h>

#include <plat/clockdomain.h>
#include "clockdomain.h"
#include "cm1_44xx.h"
#include "cm2_44xx.h"

Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/cpuidle34xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#include <plat/prcm.h>
#include <plat/irqs.h>
#include <plat/powerdomain.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"
#include <plat/serial.h>

#include "pm.h"
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/io.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#include <plat/omap-pm.h>
#include <plat/powerdomain.h>

#include <plat/clockdomain.h>
#include "clockdomain.h"
#include <plat/omap_hwmod.h>
#include <plat/multi.h>

Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/omap_hwmod.c
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@

#include <plat/common.h>
#include <plat/cpu.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"
#include <plat/powerdomain.h>
#include <plat/clock.h>
#include <plat/omap_hwmod.h>
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/pm-debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#include <plat/clock.h>
#include <plat/board.h>
#include <plat/powerdomain.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"
#include <plat/dmtimer.h>

#include "cm2xxx_3xxx.h"
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include <plat/common.h>

#include <plat/powerdomain.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"

static struct omap_device_pm_latency *pm_lats;

Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/pm24xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
#include "control.h"

#include <plat/powerdomain.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"

#ifdef CONFIG_SUSPEND
static suspend_state_t suspend_state = PM_SUSPEND_ON;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/pm34xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include <linux/console.h>

#include <plat/sram.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"
#include <plat/powerdomain.h>
#include <plat/serial.h>
#include <plat/sdrc.h>
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/powerdomain.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

#include <plat/cpu.h>
#include <plat/powerdomain.h>
#include <plat/clockdomain.h>
#include "clockdomain.h"
#include <plat/prcm.h>

#include "pm.h"
Expand Down
7 changes: 6 additions & 1 deletion drivers/staging/tidspbridge/core/_tiomap.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,13 @@
#ifndef _TIOMAP_
#define _TIOMAP_

/*
* XXX These powerdomain.h/clockdomain.h includes are wrong and should
* be removed. No driver should call pwrdm_* or clkdm_* functions
* directly; they should rely on OMAP core code to do this.
*/
#include <plat/powerdomain.h>
#include <plat/clockdomain.h>
#include <mach-omap2/clockdomain.h>
/*
* XXX These mach-omap2/ includes are wrong and should be removed. No
* driver should read or write to PRM/CM registers directly; they
Expand Down

0 comments on commit 1540f21

Please sign in to comment.