Skip to content

Commit

Permalink
sparc: prom: Sanitize return value from prom_nbputchar()
Browse files Browse the repository at this point in the history
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julian Calaby authored and David S. Miller committed Dec 12, 2010
1 parent 23bcbf1 commit 1543376
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions arch/sparc/prom/console_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@ static int prom_nbputchar(const char *buf)
spin_lock_irqsave(&prom_lock, flags);
switch(prom_vers) {
case PROM_V0:
i = (*(romvec->pv_nbputchar))(*buf);
if ((*(romvec->pv_nbputchar))(*buf))
i = 1;
break;
case PROM_V2:
case PROM_V3:
if ((*(romvec->pv_v2devops).v2_dev_write)(*romvec->pv_v2bootargs.fd_stdout,
buf, 0x1) == 1)
i = 0;
i = 1;
break;
default:
break;
Expand All @@ -47,7 +48,7 @@ void prom_console_write_buf(const char *buf, int len)
{
while (len) {
int n = prom_nbputchar(buf);
if (n)
if (n < 0)
continue;
len--;
buf++;
Expand Down

0 comments on commit 1543376

Please sign in to comment.