Skip to content

Commit

Permalink
sysctl extern cleanup: sg
Browse files Browse the repository at this point in the history
Extern declarations in sysctl.c should be moved to their own header file,
and then include them in relavant .c files.

Move sg_big_buff extern declaration to scsi/sg.h

Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Acked-by: Doug Gilbert <dgilbert@interlog.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Dave Young authored and Linus Torvalds committed Mar 12, 2010
1 parent 5ed1091 commit 15485a4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 3 additions & 0 deletions include/scsi/sg.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ Major new features in SG 3.x driver (cf SG 2.x drivers)
(for the lk 2.2 series).
*/

#ifdef __KERNEL__
extern int sg_big_buff; /* for sysctl */
#endif

/* New interface introduced in the 3.x SG drivers follows */

Expand Down
7 changes: 3 additions & 4 deletions kernel/sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@
#include <asm/stacktrace.h>
#include <asm/io.h>
#endif
#ifdef CONFIG_CHR_DEV_SG
#include <scsi/sg.h>
#endif


#if defined(CONFIG_SYSCTL)
Expand Down Expand Up @@ -116,10 +119,6 @@ static int min_percpu_pagelist_fract = 8;

static int ngroups_max = NGROUPS_MAX;

#ifdef CONFIG_CHR_DEV_SG
extern int sg_big_buff;
#endif

#ifdef CONFIG_SPARC
#include <asm/system.h>
#endif
Expand Down

0 comments on commit 15485a4

Please sign in to comment.