Skip to content

Commit

Permalink
iwlwifi: blocking mac_start until uCode is complete
Browse files Browse the repository at this point in the history
This patch makes iwl4965_mac_start block until the uCode has been
completely loaded.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Emmanuel Grumbach authored and John W. Linville committed Jun 30, 2008
1 parent 06da069 commit 154b25c
Showing 1 changed file with 10 additions and 12 deletions.
22 changes: 10 additions & 12 deletions drivers/net/wireless/iwlwifi/iwl4965-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -2566,7 +2566,7 @@ static void iwl_bg_scan_completed(struct work_struct *work)
*
*****************************************************************************/

#define UCODE_READY_TIMEOUT (2 * HZ)
#define UCODE_READY_TIMEOUT (4 * HZ)

static int iwl4965_mac_start(struct ieee80211_hw *hw)
{
Expand Down Expand Up @@ -2619,17 +2619,15 @@ static int iwl4965_mac_start(struct ieee80211_hw *hw)

/* Wait for START_ALIVE from Run Time ucode. Otherwise callbacks from
* mac80211 will not be run successfully. */
if (priv->ucode_type == UCODE_RT) {
ret = wait_event_interruptible_timeout(priv->wait_command_queue,
test_bit(STATUS_READY, &priv->status),
UCODE_READY_TIMEOUT);
if (!ret) {
if (!test_bit(STATUS_READY, &priv->status)) {
IWL_ERROR("START_ALIVE timeout after %dms.\n",
jiffies_to_msecs(UCODE_READY_TIMEOUT));
ret = -ETIMEDOUT;
goto out_release_irq;
}
ret = wait_event_interruptible_timeout(priv->wait_command_queue,
test_bit(STATUS_READY, &priv->status),
UCODE_READY_TIMEOUT);
if (!ret) {
if (!test_bit(STATUS_READY, &priv->status)) {
IWL_ERROR("START_ALIVE timeout after %dms.\n",
jiffies_to_msecs(UCODE_READY_TIMEOUT));
ret = -ETIMEDOUT;
goto out_release_irq;
}

priv->is_open = 1;
Expand Down

0 comments on commit 154b25c

Please sign in to comment.