Skip to content

Commit

Permalink
typhoon: wait for RX mode commands to finish
Browse files Browse the repository at this point in the history
When adding VLAN devices, we can get several calls to
typhoon_set_rx_mode() in quick succession. Because we didn't wait for
the commands to complete, we could run out of command descriptors and
fail to set the RX mode.

Signed-off-by: David Dillow <dave@thedillows.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David Dillow authored and David S. Miller committed Oct 24, 2010
1 parent 5c398dc commit 154ccd8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/typhoon.c
Original file line number Diff line number Diff line change
Expand Up @@ -936,7 +936,7 @@ typhoon_set_rx_mode(struct net_device *dev)
filter |= TYPHOON_RX_FILTER_MCAST_HASH;
}

INIT_COMMAND_NO_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER);
INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER);
xp_cmd.parm1 = filter;
typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL);
}
Expand Down

0 comments on commit 154ccd8

Please sign in to comment.