Skip to content

Commit

Permalink
[media] cx231xx: simplify argument passing to cx231xx_init_dev()
Browse files Browse the repository at this point in the history
The 'struct cx231xx *' pointer was passed by reference to the
cx231xx_init_dev() function, for no reason. Instead, just pass it by
value, which is much more logical and simple.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Thomas Petazzoni authored and Mauro Carvalho Chehab committed Jan 11, 2012
1 parent 9e94136 commit 15cb6af
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/media/video/cx231xx/cx231xx-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -868,10 +868,9 @@ void cx231xx_release_resources(struct cx231xx *dev)
* cx231xx_init_dev()
* allocates and inits the device structs, registers i2c bus and v4l device
*/
static int cx231xx_init_dev(struct cx231xx **devhandle, struct usb_device *udev,
static int cx231xx_init_dev(struct cx231xx *dev, struct usb_device *udev,
int minor)
{
struct cx231xx *dev = *devhandle;
int retval = -ENOMEM;
int errCode;
unsigned int maxh, maxw;
Expand Down Expand Up @@ -1154,7 +1153,7 @@ static int cx231xx_usb_probe(struct usb_interface *interface,
return -EIO;
}
/* allocate device struct */
retval = cx231xx_init_dev(&dev, udev, nr);
retval = cx231xx_init_dev(dev, udev, nr);
if (retval) {
clear_bit(dev->devno, &cx231xx_devused);
v4l2_device_unregister(&dev->v4l2_dev);
Expand Down

0 comments on commit 15cb6af

Please sign in to comment.