Skip to content

Commit

Permalink
V4L/DVB: cx88: Move I2C IR initialization
Browse files Browse the repository at this point in the history
Move I2C IR initialization from just after I2C bus setup to right
before non-I2C IR initialization. This is the same as was done for
the bttv driver several months ago. Might solve bugs which have not yet
been reported for some cards. It makes both drivers consistent, and
makes it easier to disable IR support (coming soon.)

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Jean Delvare authored and Mauro Carvalho Chehab committed Aug 2, 2010
1 parent 7d7b528 commit 15ceb6b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions drivers/media/video/cx88/cx88-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -3498,6 +3498,7 @@ struct cx88_core *cx88_core_create(struct pci_dev *pci, int nr)
}

cx88_card_setup(core);
cx88_i2c_init_ir(core);
cx88_ir_init(core, pci);

return core;
Expand Down
6 changes: 5 additions & 1 deletion drivers/media/video/cx88/cx88-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@ int cx88_i2c_init(struct cx88_core *core, struct pci_dev *pci)
} else
printk("%s: i2c register FAILED\n", core->name);

return core->i2c_rc;
}

void cx88_i2c_init_ir(struct cx88_core *core)
{
/* Instantiate the IR receiver device, if present */
if (0 == core->i2c_rc) {
struct i2c_board_info info;
Expand All @@ -207,7 +212,6 @@ int cx88_i2c_init(struct cx88_core *core, struct pci_dev *pci)
}
}
}
return core->i2c_rc;
}

/* ----------------------------------------------------------------------- */
Expand Down
1 change: 1 addition & 0 deletions drivers/media/video/cx88/cx88.h
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,7 @@ extern struct videobuf_queue_ops cx8800_vbi_qops;
/* cx88-i2c.c */

extern int cx88_i2c_init(struct cx88_core *core, struct pci_dev *pci);
extern void cx88_i2c_init_ir(struct cx88_core *core);


/* ----------------------------------------------------------- */
Expand Down

0 comments on commit 15ceb6b

Please sign in to comment.