Skip to content

Commit

Permalink
ide: Fix cs5535 driver accessing beyond array boundary
Browse files Browse the repository at this point in the history
The cs5535 uses an incorrect construct to access the other drive of a pair,
causing it to access beyond an array boundary on the secondary interface.

This fixes it by using the new ide_get_paired_drive() helper instead.

Bart: patch description fixes

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Benjamin Herrenschmidt authored and Bartlomiej Zolnierkiewicz committed Oct 18, 2007
1 parent a87a87c commit 15d8061
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ide/pci/cs5535.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ static void cs5535_set_speed(ide_drive_t *drive, const u8 speed)

/* Set the PIO timings */
if ((speed & XFER_MODE) == XFER_PIO) {
ide_drive_t *pair = &drive->hwif->drives[drive->dn ^ 1];
ide_drive_t *pair = ide_get_paired_drive(drive);
u8 cmd, pioa;

cmd = pioa = speed - XFER_PIO_0;
Expand Down

0 comments on commit 15d8061

Please sign in to comment.